Re: [Xen-devel] [PATCH] libxen compilation fixes

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Keir Fraser writes ("Re: [Xen-devel] [PATCH] libxen compilation fixes"):
> -Wno-declaration-after-statement is not supported by gcc older than 3.4.
> Also it should be the default behaviour anyway, even with -Wall, and libxen
> throws away the passed-in CFLAGS so it will never see
> -Wdeclaration-after-statement.

I must have missed an earlier -Wdeclaration-after-statement provided
by some package build script, then.  Sorry.

> What would be nice would be to make libxen not throw away provided CFLAGS
> and, if it's not too far gone down the declaration-after-statement route,
> fix it to put its declarations at the top of blocks like a good C program.
> If that's a big job though it's probably not worth the bother.

I think libxen is too far gone.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel