[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] linux: {start, stop}_hz_timer() not really affecting periodic timer?

  • To: Jan Beulich <jbeulich@xxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Wed, 16 Jan 2008 18:26:53 +0000
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 16 Jan 2008 10:27:11 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AchYbV3knJhsJsRgEdyOUgAWy6hiGQ==
  • Thread-topic: [Xen-devel] linux: {start, stop}_hz_timer() not really affecting periodic timer?

On 16/1/08 17:17, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>>> Immediately would mean to me that it would fire on the return path
>>> from VCPUOP_set_singleshot_timer, so HYPERVISOR_block() would
>>> not (necessarily) find any pending events and hence block when it
>>> shouldn't. Or am I missing some magic by which this is being avoided?
>> The function should only be called with interrupts disabled.
> That goes back to what I stated first - there's nothing really requiring
> this, it just happens to be that way at present.

If you don't do this then the function doesn't work properly, so in that
sense it is a requirement! If you want it more explicit add a comment or
maybe even a BUG_ON().

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.