Re: [Xen-devel] linux: {start, stop}_hz_timer() not really affecting periodic timer?

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 16/1/08 17:17, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>>> Immediately would mean to me that it would fire on the return path
>>> from VCPUOP_set_singleshot_timer, so HYPERVISOR_block() would
>>> not (necessarily) find any pending events and hence block when it
>>> shouldn't. Or am I missing some magic by which this is being avoided?
>> 
>> The function should only be called with interrupts disabled.
> 
> That goes back to what I stated first - there's nothing really requiring
> this, it just happens to be that way at present.

If you don't do this then the function doesn't work properly, so in that
sense it is a requirement! If you want it more explicit add a comment or
maybe even a BUG_ON().

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel