[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] do_callback_op()'s second argument can be const

  • To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Fri, 18 Jan 2008 15:11:13 +0000
  • Delivery-date: Fri, 18 Jan 2008 07:11:41 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AchZ5F0im9AxbsXXEdyBqQAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] do_callback_op()'s second argument can be const

On 18/1/08 15:05, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> I certainly don't see how the chunk below fixes
>> anything -- doesn't it take two lines to state what took one line before?
> It fixes the build in the context of the other changes.

What's the difference between assigning from a variable that is void* and
assigning from a variable that you have cast to void*? Is this just to get
round some stupid compiler warning that shouldn't happen in the first place?
That's why I hate type attributes: const, volatile, and the rest. Stupid
waste of time.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.