[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] do_callback_op()'s second argument can beconst

>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 18.01.08 16:11 >>>
>On 18/1/08 15:05, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>>> I certainly don't see how the chunk below fixes
>>> anything -- doesn't it take two lines to state what took one line before?
>> It fixes the build in the context of the other changes.
>What's the difference between assigning from a variable that is void* and
>assigning from a variable that you have cast to void*? Is this just to get
>round some stupid compiler warning that shouldn't happen in the first place?
>That's why I hate type attributes: const, volatile, and the rest. Stupid
>waste of time.

It's been a while since I wrote this, and I can't reproduce any issue anymore
when I remove it. I must have forgotten to undo that change once it wasn't
needed anymore - sorry about that.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.