[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] do_callback_op()'s second argument can be const

>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 18.01.08 16:44 >>>
>On 18/1/08 15:11, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote:
>>>> I certainly don't see how the chunk below fixes
>>>> anything -- doesn't it take two lines to state what took one line before?
>>> It fixes the build in the context of the other changes.
>> What's the difference between assigning from a variable that is void* and
>> assigning from a variable that you have cast to void*? Is this just to get
>> round some stupid compiler warning that shouldn't happen in the first place?
>> That's why I hate type attributes: const, volatile, and the rest. Stupid
>> waste of time.
>I removed the chunk and I can't get the build to fail on i386 or x86_64 with
>gcc 3.4 or gcc 4.1. Perhaps you build with more anal gcc warning settings?

Neither can I, as said already. I'm not using more strict compiler settings,
but one thing I could imagine is that I first tested the constructs involved
outside of Xen (and then with -Wall -W) and got some warning. But as said
in the other reply, it may also be that this was simply a leftover.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.