[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: ioemu: use asprintf instead of PATH_MAX

Mike D. Day, le Wed 23 Jan 2008 15:53:47 -0500, a écrit :
> erOn 23/01/08 17:20 +0000, Samuel Thibault wrote:
> > Use asprintf instead of PATH_MAX, which POSIX says to be facultative.
> > 
> > Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
> > -        snprintf(qemu_file, sizeof(qemu_file), 
> > -                 "/var/lib/xen/qemu-save.%d", domid);
> > +        asprintf(&qemu_file, "/var/lib/xen/qemu-save.%d", domid);
> Just a question - afaik asprintf is a unix-ism that isn't supported on
> windows. Will this cause problems if also pushed to upstream qemu?

qemu is quite often used in windows too so that would pose problem
indeed.  But I guess the /var/lib patch would too anyway :)  And this
part of the code is actually xen-specific.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.