[Xen-devel] Re: ioemu: use asprintf instead of PATH_MAX

["Mike D. Day" <ncmike@xxxxxxxxxx>]

On 24/01/08 01:38 +0000, Samuel Thibault wrote:
> Mike D. Day, le Wed 23 Jan 2008 15:53:47 -0500, a Ãcrit :
> > erOn 23/01/08 17:20 +0000, Samuel Thibault wrote:
> > > Use asprintf instead of PATH_MAX, which POSIX says to be facultative.
> > > 
> > > Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
> > 
> > > -        snprintf(qemu_file, sizeof(qemu_file), 
> > > -                 "/var/lib/xen/qemu-save.%d", domid);
> > > +        asprintf(&qemu_file, "/var/lib/xen/qemu-save.%d", domid);
> > 
> > Just a question - afaik asprintf is a unix-ism that isn't supported on
> > windows. Will this cause problems if also pushed to upstream qemu?
> 
> qemu is quite often used in windows too so that would pose problem
> indeed.  But I guess the /var/lib patch would too anyway :)  And this
> part of the code is actually xen-specific.

Yes, true. At a higher scope, what are current plans for a merge with
upstream Qemu? Is the process to merge upstream or to continue
maintaining the Xen differences out-of-tree?

thanks, 

Mike

-- 
Mike D. Day
IBM LTC
Cell: 919 412-3900
Sametime: ncmike@xxxxxxxxxx AIM: ncmikeday  Yahoo: ultra.runner
PGP key: http://www.ncultra.org/ncmike/pubkey.asc

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel