[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/4] tools - Remove machine setting from HOSTCFLAGS

On 26/1/08 19:34, "Bastian Blank" <bastian@xxxxxxxxxxxx> wrote:

> # HG changeset patch
> # User Bastian Blank <waldi@xxxxxxxxxx>
> # Date 1201375662 -3600
> # Node ID 15419f59710aeaaf83fc35fbbf955b15ec713051
> # Parent  c98a1a50be44c52cb59b5795347bf852941b4fdc
> Remove machine setting from HOSTCFLAGS.
> The host compiler must know how to produce runnable binaries without
> special settings.
> Signed-off-by: Bastian Blank <waldi@xxxxxxxxxx>

Unfortunately those lines *were* introduced for a reason. See the thread at
http://lists.xensource.com/archives/html/xen-devel/2007-08/msg00342.html. In
brief summary, the HOSTCFLAGS mod ensures that Solaris gcc produces 64-bit
binaries when COMPILE_ARCH==x86_64; a sane thing to do you'll agree.

We could move the HOSTCFLAGS modification to config/SunOS.mk. Or to
tools/include/xen-foreign/Makefile. But actually afaict doing it globally in
Config.mk is harmless, it just looks a bit odd and potentially purgable. :-)

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.