[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel][PATCH][ioemu] strip tap subtype prefix from image name (restyled)





On 30/1/08 14:38, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>>   out:
>> +    free(drv);
>> +    free(buf);
>> +    free(bpath);
>>      free(image);
>>      free(vec);
> 
> That doesn't work. If strdup() fails, then drv and buf are NULL here.
> Analagous counts for the other failures.
> You need to check for != NULL before calling free().

free() is defined to accept a NULL argument.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.