[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] Simplify paging_invlpg when flush is notrequired.

  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Sun, 3 Feb 2008 17:08:32 +0800
  • Delivery-date: Sun, 03 Feb 2008 01:09:20 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AchmKe/O98M9ImhQROaw3KDvTG8qogAGJyioAAADwKA=
  • Thread-topic: [Xen-devel] [PATCH] Simplify paging_invlpg when flush is notrequired.

>From: Keir Fraser
>Sent: 2008年2月3日 16:56
>Is there a significant advantage to doing this? One other 
>comment is that I
>don't like extra boolean 0/1 arguments to functions. I'd rather have
>something like paging_invlpg() and paging_invlpg_noflush() and 
>only have the
>boolean argument to paging.mode->invlpg().
> -- Keir

No significant advantage, and just eye-balled this redundant work.
Here's updated version. Only check compilation this time.


Simplify paging_invlpg when flush is not required.

Add paging_invlpg_noflush, when flush check is not required.
It's wasteful to always validate shadow linear mapping if
caller doesn't check return value at all.

Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>


Attachment: invlpg.patch
Description: invlpg.patch

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.