Re: [Xen-devel] [PATCH] Simplify paging_invlpg when flush is not required.

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

Is there a significant advantage to doing this? One other comment is that I
don't like extra boolean 0/1 arguments to functions. I'd rather have
something like paging_invlpg() and paging_invlpg_noflush() and only have the
boolean argument to paging.mode->invlpg().

 -- Keir

On 3/2/08 05:59, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> Simplify paging_invlpg when flush is not required.
> 
> New 'flush' parameter is added to paging_invlpg, to allow
> caller assigning whether flush check is required. It's
> wasteful to always validate shadow linear mapping if caller
> doesn't check return value at all.
> 
> Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>
> 
> Thanks,
> Kevin
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel