[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] compat_mmuext_op - continuation code is wrong

  • To: John Levon <levon@xxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Wed, 20 Feb 2008 18:16:58 +0000
  • Delivery-date: Wed, 20 Feb 2008 10:17:36 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Achz7Me0Bmot5t/gEdydswAX8io7RQ==
  • Thread-topic: [Xen-devel] compat_mmuext_op - continuation code is wrong

On 20/2/08 17:21, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> But we never initialised the guest's "pdone" at any point. So we can
> copy in an uninit stack value into 'done', add 'i' to it, then copy it
> back out. On Solaris, we assert that the success count == what we passed
> in, so this breaks Solaris 32/64
> I'm running on 3.1 with a couple of fixes from unstable to make it work
> at all. The below patch works for us but I'm not confident in its
> correctness.

Better to remove the preempt check altogether, as it's already done
(correctly) in do_mmuext_op(). That's what I'll check in.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.