Re: [Xen-devel] [PATCH][retry 3][1/2] new vcpu op call to get physicalCPU information

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Jan Beulich writes ("Re: [Xen-devel] [PATCH][retry 3][1/2] new vcpu op call to 
get physicalCPU information"):
> >+    short temp = 0xff;
...
> >+    cpu_id.phys_id |= temp << 8;
> 
> Please shift by 32 here for forward compatibility.

short promotes to int, probably 32-bit, but shifting by the word size
or more is not permitted.  In any case even if it worked like you
wanted, the result would be 0.  Perhaps you meant to suggest some
changes of types as well ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel