Re: [Xen-devel] [PATCH] Initialization of new domU config options via XenAPI

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

It's quite valid not to have 'hpet' explicitly set; also I think
'timer_mode'. What problems do you see, and do they really happen with all
three config items?

 -- Keir

On 13/3/08 20:58, "Jim Fehlig" <jfehlig@xxxxxxxxxx> wrote:

> Many of the new domU config options related to hvm guests (e.g. hpet,
> rtc_timeoffset, etc.) are not initialized with default values via
> XenAPI, which prevents starting an hvm domU created through XenAPI.
> This patch ensures the new options are set with appropriate default
> values in XendConfig platform sanity check.
> 
>     Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>
> 
> diff -r f33328217eee tools/python/xen/xend/XendConfig.py
> --- a/tools/python/xen/xend/XendConfig.py Mon Mar 10 22:51:57 2008 +0000
> +++ b/tools/python/xen/xend/XendConfig.py Thu Mar 13 14:55:16 2008 -0600
> @@ -405,6 +405,12 @@ class XendConfig(dict):
>                  self['platform']['device_model'] =
> xen.util.auxbin.pathTo("qemu-dm")
>  
>          if self.is_hvm():
> +            if 'timer_mode' not in self['platform']:
> +                self['platform']['timer_mode'] = 0
> +            if 'rtc_timeoffset' not in self['platform']:
> +                self['platform']['rtc_timeoffset'] = 0
> +            if 'hpet' not in self['platform']:
> +                self['platform']['hpet'] = 0
>              if 'loader' not in self['platform']:
>                  # Old configs may have hvmloader set as PV_kernel param
>                  if self.has_key('PV_kernel') and re.search('hvmloader',
> self['PV_kernel']):
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel