[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: fix variable_test_bit() asmconstraints


  • To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Fri, 14 Mar 2008 13:57:28 +0000
  • Delivery-date: Fri, 14 Mar 2008 06:58:41 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AciF21bClZULKPHOEdyPnAAWy6hiGQ==
  • Thread-topic: [Xen-devel] [PATCH] x86: fix variable_test_bit() asmconstraints

On 14/3/08 13:51, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> because at least I'm certain that works. Same for 'asm volatile'. We've had
>> various problems with the bitops before, and I just want the darn things to
>> work!
> 
> Okay, if you feel that way then I guess I won't propose changing it,
> at the expense of slightly worse code generation.

Frankly I'm scared to change it for the minuscule benefit we would derive
from it.

Regarding your other reply: I would actually be happy to change the bitops
to work with longs only. I suspect, and would need to have demonstrated
otherwise, that supporting bitops on arbitrary-width fields down to the
instruction level is not really worthwhile. Either way, I accept that what
we do now is dubious at best.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.