[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] x86: fix variable_test_bit()asmconstraints
On 14/3/08 14:11, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: >> Regarding your other reply: I would actually be happy to change the bitops >> to work with longs only. I suspect, and would need to have demonstrated >> otherwise, that supporting bitops on arbitrary-width fields down to the >> instruction level is not really worthwhile. Either way, I accept that what >> we do now is dubious at best. > > Hmm, change it to work with longs only but also make it work without > casts? You mean then change all places where bitops are applied to > exclusively use 'unsigned long' as the fundamental type? I didn't look > at the number of places that would require changing, but I'm afraid it'd > be quite a few (and it might get you further away from Linux originals > in some cases). Yes, I wouldn't have expected that too be too hard, really. Are there lots of places with arrays of 32-bit integers? I doubt 16-bit or 8-bit fields are at all common. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |