Re: [Xen-devel] [PATCH 1/5] Add MSI support to XEN

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 28/3/08 10:03, "Shan, Haitao" <haitao.shan@xxxxxxxxx> wrote:

>>> like 'GSI' or 'ISA IRQ'. So the interface should be fixed imo.
>> 
>> Oh, I jumped in too early. Sorry and you're right.
> I will change that name.

I think you should add both. I believe there's not necessarily a guaranteed
mapping of every ISA IRQ into GSI namespace. I don't strongly insist on this
now if you know what you're doing and only want to include MAP_IRQ_TYPE_GSI.

The names should be MAP_PIRQ_* and PHYSDEVOP_[un]map_pirq, by the way.

Another comment I have is that it doesn't look like the per-domain-pirq
patch is compatible with old dom0 kernels if msi_irq_enable is specified on
the Xen command line. That's a bit sucky, especially since we're sure to
want to make msi_irq_enable the default after these patches have had some
testing. I'm not sure what to suggest as the better way to achieve backward
compatibility. I'll have a think about it...

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel