[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly tag every anonymous aggregate in the public headers.



On 31/3/08 16:49, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

> It seems pretty clear that in nesting __extension__ attributes in this
> manner, the struct is actually ignored and the compiler is treating the
> everything that was in the struct as a separate member of the union.  In
> the mapped_regs example, the structure size remains correct only because
> the union is full padded out using the full size arrays.  Please apply
> the patch I sent previously to revert the nested __extension__
> attributes.  Thanks,

__extension__ seems worryingly half-baked. We're better off asserting
!__STRICT_ANSI__ in my opinion. I don't suppose you much care either way as
long as ia64 boot works again. :-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.