Re: [Xen-devel] [PATCH]Fix memory leak for copy-receiver of netfront

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

Kasai Takanori wrote:
> Hi all,
>
> We found the problem of the memory leak when working with copy-
> receiver of netfront.
>
> The source of a problem is that the fragment page is not released with 
> dev_kfree_skb() because the nr_frags variable of skb is set to 0. 
>
> This is the patch to fix memory leak in netfront.
>   
This code doesn't apply to the current 2.6.25 version of netfront.  The 
only similar code I could see is:
               skb = np->rx_skbs[id];
               mfn = gnttab_end_foreign_transfer_ref(ref);
               gnttab_release_grant_reference(&np->gref_rx_head, ref);
               np->grant_rx_ref[id] = GRANT_INVALID_REF;

               if (0 == mfn) {
                       skb_shinfo(skb)->nr_frags = 0;
                       dev_kfree_skb(skb);
                       noxfer++;
                       continue;
               }


Would you mind reviewing the 2.6.25 version of netfront to see if it 
needs a patch?
Thanks,
   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel