Re: [Xen-devel] domain destory path is not correct on c/s 18117

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Thursday 24 July 2008 12:20:50 Keir Fraser wrote:
> On 24/7/08 11:13, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> > I just figured out, the call to arch_domain_destroy() is delayed until
> > Dom0 shutdown/reboot.
> > Changing "pages" back to int doesn't fix this.
> >
> > Keir: I suppose, c/s 18117 exposes a long standing hidden bug.
> > Reverting c/s 18117 just hides it again.
>
> Or you removed the munmap() from the tail of loadelfimage(). Putting it
> back fixes the bug. Changeset 18118.

Ah, right. I didn't notice that munmap() was called in both failure and
_succuss_ case of xc_map_foreign_ranges().
Thanks for fixing this.

Christoph


-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel