[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [PATCH] ioemu-remote: ACPI S3 state wake up



I already tried to reduce the rw area, and just keep 0xe0 -> 0xef. But obviously it doesn't work the device model needs to write on this frame 0xf1. I still don't figure out why.


Trolle Selander wrote:
Don't leave the main rombios unprotected. I also added a comment to explain the "magic numbers", since their meaning is perhaps not as obvious as I thought, in particular now that we're no longer blanket-protecting the entire firmware area anymore.

/ Trolle

Signed-off-by: Trolle Selander <trolle.selander@xxxxxxxxxxxxx <mailto:trolle.selander@xxxxxxxxxxxxx> <mailto:trolle.selander@xxxxxxxxxxxxx>

On Wed, Jul 23, 2008 at 7:02 PM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx <mailto:Ian.Jackson@xxxxxxxxxxxxx>> wrote:

    Jean Guyader writes ("[PATCH] ioemu-remote: ACPI S3 state wake up"):
     > ioemu-remote: The device model needs to write in the ACPI tables
    when it
     > wakes up from S3 state.

    I've applied this but I have to say these magic numbers
     > -        if (xc_hvm_set_mem_type(xc_handle, domid, mem_type,
    0xc0, 0x40))
     > +        if (xc_hvm_set_mem_type(xc_handle, domid, mem_type,
    0xc0, 0x20))
    are pretty unpleasant!  Are they directly derived from addresses
    specified in ACPI ?  I haven't looked ...

    Ian.

    _______________________________________________
    Xen-devel mailing list
    Xen-devel@xxxxxxxxxxxxxxxxxxx <mailto:Xen-devel@xxxxxxxxxxxxxxxxxxx>
    http://lists.xensource.com/xen-devel




--
Jean Guyader

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.