[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH 2/4] CPUIDLE: Avoid remnant LAPIC timer intrwhile force hpetbroadcast

  • To: "Wei, Gang" <gang.wei@xxxxxxxxx>, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Wed, 10 Sep 2008 22:51:31 +0800
  • Cc:
  • Delivery-date: Wed, 10 Sep 2008 07:51:57 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AckSVfqaFjPrXqrARTKdgjxn6iTeJQA2DOERAAhrdiAAAN6s4A==
  • Thread-topic: [Xen-devel] [PATCH 2/4] CPUIDLE: Avoid remnant LAPIC timer intrwhile force hpetbroadcast

>From: Wei, Gang
>Sent: 2008年9月10日 22:25
>> It's not clear to me the disable/enable_LAPIC_timer() work 
>is worthwhile for
>> the few timer interrupts it is likely to avoid. The other 
>bit of the patch
>> is a good bugfix though. I've taken just the latter part.
>Thanks for accept most of these patches. As to 
>disable/enable_LAPIC_timer(), I add them because some 
>platforms require the LAPIC timer intr being disabled before 
>entering C3, otherwise there may be some unexpected things. As 
>a reference, Linux kernel always do so.

Also this is conceptually clearer, as at given time we only
want one clock source to drive timers. It'd make little sense
to have APIC timer freely counting down to trigger spurious
interrupt when HPET/PIT already plays the role before APIC 
timer is reprogrammed upon C3 exit. :-)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.