RE: [Xen-devel] [PATCH] Dom0 Kernel - Fixes for saving/restoringMSI/MSI-X across Dom0 S3

["Shan, Haitao" <haitao.shan@xxxxxxxxx>]

No problem, given that MSI is disabled by default now.
Actually, this patch is a fix for xen3.3 and some distributions based on 
xen3.3, where MSI is still available via options.
The bug shows: S3 failed when SATA mode is set to be AHCI. I think Jan might 
know this bug already.
At least, it can be viewed as a workaround if someone is really in need of that.

Shan Haitao

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: 2008年11月24日 20:04
To: Jan Beulich; Shan, Haitao
Cc: 'xen-devel@xxxxxxxxxxxxxxxxxxx'
Subject: Re: [Xen-devel] [PATCH] Dom0 Kernel - Fixes for 
saving/restoringMSI/MSI-X across Dom0 S3

On 24/11/08 11:41, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>>>> "Shan, Haitao" <haitao.shan@xxxxxxxxx> 24.11.08 12:03 >>>
>> With this patch, MSI/MSI-X capabilities and tables are saved in Dom0 when
>> S3 and restored when resume. Actually, this is also the approach that
>> kernel takes. The only concern is that Dom0 should not touch MSI/MSI-X,
>> they are owned by VMM itself. Maybe adding a hypercall to instruct Xen to
>> do the saving/restoring is good. I wonder whether the reason is strong
>> enough for adding a hypercall for such purpose.
> 
> Is it at all necessary to use a hypercall here? Shouldn't Xen itself be able
> to
> do the necessary saving/restoring (just like it does for IO-APIC)?

I was thinking the same thing. Haitao: shall I hold off on your original
patch while we think about this?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel