[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC][PATCH] scheduler: credit scheduler for client virtualization

On 03/12/2008 08:54, "NISHIGUCHI Naoki" <nisiguti@xxxxxxxxxxxxxx> wrote:

> Please review this patch.
> Any comments are appreciated.

Don't hack it into the existing sched_credit.c unless you are really sharing
significant amounts of stuff (which it looks like you aren't?).
sched_bcredit.c would be a cleaner name if there's no sharing. Is a new
scheduler necessary -- could the existing credit scheduler be generalised
with your boost mechanism to be suitable for both client and server?

The issue with multiple schedulers is that it's most likely the non-default
will not be tested, used or maintained. The default credit scheduler gets
little enough love as it is, and it's really the only sensible scheduler to
choose now (SEDF is not great -- good example of a rotten non-default

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.