[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: [patch 0/3]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs

Hi, Keir

Thanks a lot for the clean-up and format refine! I will pay more attention to 
this too.And also I tested on the related platform. It's fine.

As for moving *cmci_owner_set* out of stopmachine_run is basically ok for us. 
Just one thing:  
CMCI might happen and lost during the very small window (old owner is cleared 
while new owner is not set). In order to make sure that CMCI could be triggered 
an on the new owner, we need to clear MSR Bank(i) status register [Corrected 
Error Counter] field ( We normally do this @ CMCI interrupt handler, according 
to spec, if the counter is not cleared, CMCI will not be triggered any more).
I made a small patch for it in the attachment. How do you think?

Thanks a lot!

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: 2008年12月22日 20:07
To: Ke, Liping
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [patch 0/3]Enable CMCI (Corrected Machine Check Error Interrupt) 
for Intel CPUs

On 22/12/2008 03:54, "Ke, Liping" <liping.ke@xxxxxxxxx> wrote:

> Hi, All
> According to Keir's suggestion, I re-organize those patches and make sure that
> each intermediate patch could be compiled and running.
> Since remove old p4 and p6 files are hard to be split, I now put the remove
> and replace in the one patch. Is it ok?
> Any comment, just let me know.

I checked in the patches as c/s 18938 and then cleaned up significantly as
c/s 18939. Let me know if this stops things working for you. Notice I
deleted more than I added. ;-)

 -- Keir

Attachment: clear_error_count.patch
Description: clear_error_count.patch

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.