Re: [Xen-devel] Re: [patch 0/3]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 24/12/2008 08:46, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:

>> You only need hardirqs disabled, so rendezvous within an on_each_cpu()
>> callback is sufficient for you. You don't need to get intimate with
>> stop_machine_run()!
> 
> Yes, that's what I mean of "do similar thing in the cmci_cpu_down()". We
> placed it in stop_machine_run() because it has rendezvous all CPU already :$

Yeah, on_each_cpu() rendezvous is pretty cheap. May as well have cleaner
partitioned code than avoid an extra rendezvous.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel