Re: [Xen-devel] [PATCH] Fix xenoprof counter overflow check

["Niraj Tolia" <ntolia@xxxxxxxxx>]

On Tue, Jan 6, 2009 at 2:15 PM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:

On 06/01/2009 18:37, "Niraj Tolia" <ntolia@xxxxxxxxx> wrote:

> While the mainline patch won't build, the one attached definitely does. That
> said, I see your point about the overflow. Now I need to figure out why this
> broken patch actually enables xenoprof to work on my Intel Xeon. The only
> reason would be the switch from CTR_READ() (which uses rdmsr() internally) to
> rdmsrl() but let me dig into it.

The patch absolutely did not build. There were still references to local
variables ('low' and 'high') that you removed the definitions of.

Ah. My patch was generated against xen-3.3-testing.hg. I just noticed that the same function has a number of changes in xen-unstable and would cause a build failure. Sorry about that.

Niraj
 

 -- Keir

-- 
Niraj Tolia, Researcher, HP Labs
http://www.hpl.hp.com/personal/Niraj_Tolia/
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel