Re: [Xen-devel] [PATCH 0/6] MSI-INTx interrupt translation for HVM

[Shohei Fujiwara <fujiwara-sxa@xxxxxxxxxxxxxxx>]

On Tue, 13 Jan 2009 17:28:13 +0800
Qing He <qing.he@xxxxxxxxx> wrote:

> On Tue, 2009-01-13 at 17:05 +0800, Shohei Fujiwara wrote:
> > What I understand are the followings.
> > Second, it is nice to create blacklist of unsuitable devices for MSI-INTx
> > interrupt, isn't it? The reason is the problem seems device-specific 
> > problem.
> 
> This is reasonable, however, I don't know a real unsuitable at this
> time. Isn't it better to add the blacklist when there is the real need?
> 
> What do you think?

I think adding blacklist now is better, because it is easy to specify
an unsuitable device when it is found. But I don't know what other
developers think about this.


BTW, I found a issue when I read your code.

MSI-INTx translation is enabled when guest domain is started.
When guest OS enables MSI/MSI-X, MSI-INTx translation is disabled.
But when guest OS disables MSI/MSI-X, MSI-INTx translation isn't re-enabled.
This means normal INTx interrupt is used.

I think the results should be the same at all times,
so it is good to re-enable MSI-INTx translation.

Thanks,
--
Shohei Fujiwara


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel