Re: [Xen-devel] [Patch] fix xenfb_update_screen bogus rect

[Markus Armbruster <armbru@xxxxxxxxxx>]

Akio Takebe <takebe_akio@xxxxxxxxxxxxxx> writes:

> Hi, Markus and Jan
>
> Markus Armbruster wrote:
>> "Jan Beulich" <jbeulich@xxxxxxxxxx> writes:
>>
>>> Generally this looks okay (assuming it works), but couldn't the 
>>> update_wanted
>>> field then go away altogether?
>>>
>>> Jan
>>
>> I think so, yes.  Start the kthread only when request-update.
>>
> Thank you for your review.
> The patch was commited already.
> So I made an additional patch which eliminate the update_wanted field.
>
> Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
>
> Best Regards,
>
> Akio Takebe

Looks good to me.

A possible reason not to take this cleanup is the fact that this
version of the driver is a dead end (the living end lives in current
upstream kernels).  Perhaps only true fixes with minimal structural
impact are desired because of that.  Not my call to make.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel