Re: [Xen-devel] [PATCH] pygrub: make it work

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Frank van der Linden writes ("Re: [Xen-devel] [PATCH] pygrub: make it work"):
> Ian Jackson wrote:
> > I think it would be better to have something that is the same
> > everywhere so I'd encourage you to resubmit without the special
> > casing (and I'll help fix it if it goes wrong).
> 
> I don't have much time right now to test on Linux, but I'll see if I 
> can. Maybe Christoph can too.

No, I mean, please resubmit the patch without test for Linux.  We
should apply it.  The changes you quote look sensible to me.  If they
break for someone I will help them debug it or do it myself.

> The comments do explain what was wrong with the old code..
> The old code had the following problems:

The explanation you just gave was what I was looking for.  In general
I think there is a difference between explaining the code as it
currently is and explaining what was wrong with the old code.

The former should be done in comments (if and only if it is not
sufficiently clear from the code itself), and the latter should be
done in checkin comments.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel