[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] introduce __must_be_array



On 20/05/2009 06:39, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> Would simply removing the cast to void from BUILD_BUG_ON() lead to compiler
>> warnings?
> 
> While I didn't try it, I'm convinced it would.

I tried it (gcc 4.1.2) and it didn't. And I'm not sure what the theoretical
warning message would be: Throwing away a non-void value? We do that with
return values from functions very often.

I'll change BUILD_BUG_ON() and avoid BUILD_BUG_ON_ZERO(), but revert to your
approach if some gccs turn out to act differently.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.