Re: [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Christoph Egger <Christoph.Egger@xxxxxxx> 15.06.09 17:33 >>>
>@@ -174,8 +177,11 @@ wakeup_64:
>         mov     $(__HYPERVISOR_DS64), %eax
>         mov     %eax, %ds
> 
>-        # long jump to return point, with cs reload
>-        rex64 ljmp    *ret_point(%rip)
>+        /* Continue with wakeup in the high-level wakeup code.
>+         * Reload cs there.
>+         */
>+        movq    ret_point(%rip), %rbx
>+        jmp     *%rbx
> 
>         .align 8
> ret_point:

Why do you add a comment ("Reload cs here") here that is not in sync with
the changed code?

Also, if the sole reference ro ret_point is now a near jump, why don't you
remove the selector part of ret_point itself? Further more, why does this
need to be an indirect jump now that it's not a far jump anymore?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel