Re: [Xen-devel] [pvops-dom0] Adding MCA logging support in pv_ops

[Christoph Egger <Christoph.Egger@xxxxxxx>]

Hi Ke Liping!

The xen mca public header needs some comment updates in the xen tree first
before it populates to the guests:

In line 102, uncorrectable errors are not reported via nmi handlers.
Please update the comment to match the code.

In struct mcinfo_recovery, it is not obvious that the REC_ACTION_* flags are 
intended to be used in action_flags. Please add a comment to make this clear.

In struct mcinfo_recovery, it is not obvious that the MC_ACTION_* flags are
intended to be used in action_types. Actually are these flags?
These are defined as a bitfield, but the union can't store more than one 
action. Please add a comment to clarify this.

For xen_mc_notifydomain, it is not clear if this has to be used before or 
after acknowledging the fetched telemetry. Please update the comment
to clarify this.

In xen_mc_notifydomain, the comment this the flags field may contain 
XEN_MC_TRAP which doesn't exist. Please update the comment.

Christoph



On Thursday 30 July 2009 07:15:05 Ke, Liping wrote:
> Hi, Jeremy and Keir
>
> This patch is backport from DOM0 cs902
>
> When an MCE/CMCI error happens (or by polling), the related error
> information will be sent to DOM0 by XEN. This patch will help to fetch
> the xen-logged information by hypercall and then convert XEN-format
> log into Linux format MCELOG. It makes using current available mcelog
> tools for native Linux possible.
>
> With this patch, after mce/cmci error log information is sent to DOM0,
> running mcelog tools in DOM0, you will get same detailed decoded mce
> information as in Native Linux.
>
> Signed-Off-By: Liping Ke <liping.ke@xxxxxxxxx>
> Signed-Off-By: Yunhong Jiang <yunhong.jiang@xxxxxxxxx>
>
>
> Thanks& Regards,
> Criping



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel