Re: [Xen-devel] [RFC] save image file format CHANGE (minor, but feedback appreciated)

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 30/07/2009 23:05, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

> It appears that the "next negative number as marker"
> mechanism only works for data that trails the last
> iteration of (mapped) pages, and thus works only after
> the domain has been suspended.  (True?)

No. It so happens that all such markers are emitted after saved pages right
now, but you can see in xc_domain_restore.c that markers are detected right
at the top of the read pages loop. You could add a new marker, emit it
before any pages in xc_domain_save.c, and pick it up just fine in the
restore loop. You'd read the rest of your stuff and act on it, then do a C
'continue' to kick off the next loop iteration, which would presumably start
reading ordinary saved memory pages.

Your patch is definitely not required.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel