Re: [Xen-devel] [PATCH] x86/dom0: support bzip2 and lzma compressed bzImage payloads

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Ian Campbell <Ian.Campbell@xxxxxxxxxx> 06.11.09 09:56 >>>
>On Thu, 2009-11-05 at 14:24 +0000, Jan Beulich wrote:
>> This matches functionality in the tools already supporting the same for
>> DomU-s.
>> 
>> Code taken from Linux 2.6.32-rc and adjusted as little as possible to
>> be usable in Xen.
>
>Looks good to me. The new files FOO.c are based on lib/decompress_FOO.c
>from Linux? Might be worth a comment in at least the changelog to aid

Yes.

>the next person to come along who wants to resync them. (and why rename
>them?)

The decompress_* prefix seemed pointless to me.

>> The question is whether, particularly for non-Linux Dom0-s, plain ELF
>> images compressed by bzip2 or lzma should also be supported.
>
>It should be fairly low cost to do so, so why not?
>
>Is there a reason to treat gzip differently to bzip2/lzma? i.e. why not
>route it through decompress.c as well? Perhaps that would involve
>updating xen/common/inflate.c but that is already just a fork of what is
>now in lib/decompress_inflate.c in Linux so it should be pretty trivial.

Yes, I had considered that, but didn't want the patch to become bigger
than necessary. I'm certainly planning on cleaning this up as a subsequent
(though lower priority) patch.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel