Re: [Xen-devel] [PATCH] x86/dom0: support bzip2 and lzma compressed bzImage payloads

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2009-11-06 at 09:02 +0000, Jan Beulich wrote:
> >>> Ian Campbell <Ian.Campbell@xxxxxxxxxx> 06.11.09 09:56 >>>
> >On Thu, 2009-11-05 at 14:24 +0000, Jan Beulich wrote:

> >the next person to come along who wants to resync them. (and why rename
> >them?)
> 
> The decompress_* prefix seemed pointless to me.

I guess it just highlights all those files as being part of the same
"subsystem".

> >> The question is whether, particularly for non-Linux Dom0-s, plain ELF
> >> images compressed by bzip2 or lzma should also be supported.
> >
> >It should be fairly low cost to do so, so why not?
> >
> >Is there a reason to treat gzip differently to bzip2/lzma? i.e. why not
> >route it through decompress.c as well? Perhaps that would involve
> >updating xen/common/inflate.c but that is already just a fork of what is
> >now in lib/decompress_inflate.c in Linux so it should be pretty trivial.
> 
> Yes, I had considered that, but didn't want the patch to become bigger
> than necessary. I'm certainly planning on cleaning this up as a subsequent
> (though lower priority) patch.

Great, thanks!

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel