Re: [Xen-devel] Re: APIC rework

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

On 11/16/09 19:13, Zhang, Xiantao wrote:
> Jeremy Fitzhardinge wrote:
>> Is there any way for the dom0 kernel to tell whether the hypervisor is
>> implementing the new ABI, so it can choose how to set up interrupts.
>>
>> MAP_COMPAT_BIT doesn't seem like a very good name, because it implies
>> that setting it reverts to "compatible" behaviour.  I assume that
>> leaving it clear enables the historical behaviour and setting it
>> enables the new one (since old kernels won't be setting it).
>>     
> Maybe better change to MAP_NEW_ABI_BIT ?  Since the hypervisor patch didn't 
> change old code path after introducing this bit, so it is very easy and safe 
> to backport to xen-3.4-testing tree, and make new dom0 be able to run top of 
> it.  :)
>   

Better to give it a name which actually describes what it means/does. 
NEW_ABI isn't very descriptive when it becomes *the* ABI (and what
happens when there's a newer one?).

    J
> Xiantao
>   


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel