Re: [Xen-devel] [PATCH] cleanup for __start_xen()

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Xiao Guangrong writes ("[Xen-devel] [PATCH] cleanup for __start_xen()"):
> Remove repetitive judgment in __start_xen()
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
> 
> diff --git a/a/xen/arch/x86/setup.c b/b/xen/arch/x86/setup.c
> index d87d082..563e46a 100644
> --- a/a/xen/arch/x86/setup.c
> +++ b/b/xen/arch/x86/setup.c
> @@ -729,7 +729,7 @@ void __init __start_xen(unsigned long mbi_p)
>  #endif
>  
>          /* Is the region suitable for relocating the multiboot modules? */
> -        if ( !initial_images_start && (s < e) &&
> +        if ( !initial_images_start &&

This is wrong.  s and e are uint64_t so if !(s < e), (e-s) will be
large and positive.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel