[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] cleanup for __start_xen()

To: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 30 Nov 2009 17:42:00 +0000
Cc:
Delivery-date: Mon, 30 Nov 2009 09:42:23 -0800
List-id: Xen developer discussion <xen-devel.lists.xensource.com>

I wrote:
> Xiao Guangrong writes ("[Xen-devel] [PATCH] cleanup for __start_xen()"):
> > -        if ( !initial_images_start && (s < e) &&
> > +        if ( !initial_images_start &&
> 
> This is wrong.  s and e are uint64_t so if !(s < e), (e-s) will be
> large and positive.

I see this has already been applied (20523).  It should be reverted, I
think.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH] cleanup for __start_xen()
  - From: Keir Fraser

References:
- [Xen-devel] [PATCH] cleanup for __start_xen()
  - From: Xiao Guangrong
- Re: [Xen-devel] [PATCH] cleanup for __start_xen()
  - From: Ian Jackson

Prev by Date: Re: [Xen-devel] [PATCH] cleanup for __start_xen()
Next by Date: [Xen-devel] [PATCH] tmem: add basic tmem freeable info to xentop
Previous by thread: Re: [Xen-devel] [PATCH] cleanup for __start_xen()
Next by thread: Re: [Xen-devel] [PATCH] cleanup for __start_xen()
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.