Re: [Xen-devel] [PATCH] cleanup for __start_xen()

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 30/11/2009 17:42, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> I wrote:
>> Xiao Guangrong writes ("[Xen-devel] [PATCH] cleanup for __start_xen()"):
>>> -        if ( !initial_images_start && (s < e) &&
>>> +        if ( !initial_images_start &&
>> 
>> This is wrong.  s and e are uint64_t so if !(s < e), (e-s) will be
>> large and positive.
> 
> I see this has already been applied (20523).  It should be reverted, I
> think.

None of the if() blocks in the loop will make e<s, as that would imply that
the block had allocated itself a chunk of memory that starts below s. So it
is actually safe to remove the checks, as we know e>=s. But now I look at it
I think I broke the module-relocation block some time ago -- it ends up with
'e' being too large by modules_headroom. :-( Will look into that more
tomorrow...

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel