[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] linux/balloon: prefer using pages from balloon in alloc_empty_pages_and_pagevec()
>>> "Jan Beulich" <JBeulich@xxxxxxxxxx> 16.12.09 16:13 >>> >Likely also something that could be done in the pv-ops tree (though it >would need some adjustment to deal with the balloon_order!=0 case). ... which seems to be broken at present anyway: The main loops in {alloc,free}_empty_pages_and_pagevec() both did not get their upper bound updated correctly (should be npages, but was left to be nr_pages), for alloc_empty_pages_and_pagevec() the wrong value is also being used to allocate pagevec[] (though I really think that this shouldn't allocate more than a nr_pages vector to avoid a rather large but unnecessary kmalloc() when nr_pages is small), and in its error path only a single page gets freed (rather than the whole balloon_order chunk). Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |