Re: [Xen-devel] build fixes

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Tuesday 12 January 2010 18:22:01 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] build fixes"):
> > Attached patch fixes Xen build on NetBSD.
>
> Nack.

?

> > +#include <sys/wait.h> /* for pid_t */
>
> This is fine but should read:
>    #include <sys/wait.h>
> as there is no point putting
>    /* for somethingorother */
> after every #include.
>
> > -        if (!isdigit(p[i])) {
> > +        if (!isdigit((uint8_t)p[i])) {
>
> This is correct on all platforms.  But it should be fixed by some more
> general approach, as it's needed for almost every call to a ctype
> macro.

Any suggestions ?

> > -    seek_ret = lseek64(fd, i << PAGE_SHIFT, SEEK_SET);
> > +    seek_ret = lseek(fd, i << PAGE_SHIFT, SEEK_SET);
>
> This is just wrong.  It will break on >2G files.

No, lseek64() doesn't exist. lseek() works fine on files > 2GB on NetBSD.
I think, on Linux you need to define LARGEFILES or something like that.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel