Re: [Xen-devel] build fixes

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 12/01/2010 17:22, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

>> -    seek_ret = lseek64(fd, i << PAGE_SHIFT, SEEK_SET);
>> +    seek_ret = lseek(fd, i << PAGE_SHIFT, SEEK_SET);
> 
> This is just wrong.  It will break on >2G files.

We build everything under tools/ with LFS support enabled, so off_t is 64
bits even in 32-bit environments. FYI The bits to enable LFS support are in
tools/Rules.mk.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel