RE: [Xen-devel] first attempt of pvscai backend driver port to pvops

["James Harper" <james.harper@xxxxxxxxxxxxxxxx>]

> 
> It does need some cleaning up.  Run it through
> linux/scripts/checkpatch.pl and iterate until its fairly clean (as
clean
> as possible without making it barbarous).  Most obvious is that kernel
> code uses 8-width hard tabs.
> 
> The patch also seems to contain usbback.  Did you mean to include it?

I sure didn't. Not sure how that got there...
 
> If possible and sensible, split the patch into logically separate
parts
> (like introduce infrastructure, use infrastructure for a, for b, for
> c).  However for these kinds of "new subsystem" patches, it often
makes
> most sense to just have one large patch adding the new code.
> 
> Please base the patches on (ideally) 2.6.31 or .32.  If you need some
> Xen infrastructure (which is likely), then base the patch on the
> xen/dom0/backend/common branch.

They are based on xen/master at the moment.

> Mail your patches to the list for review (but, please, inlined plain
> text).  But the easiest way for me to include the patches is if I can
> pull them from your git server.  If you can't make your own machine
> accessible, you can set up an account on github.com, or ask for an
> account on kernel.org.

I'll look at doing that.

> 
> I haven't actually looked at the substance of the patch yet.
> 

Probably best not to bother until I've cleaned up some of the above.

Thanks

James


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel