[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Fwd: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity


  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: Dulloor <dulloor@xxxxxxxxx>
  • Date: Tue, 30 Mar 2010 10:42:18 -0400
  • Cc: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
  • Delivery-date: Tue, 30 Mar 2010 07:43:05 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=WMYOMWAVrgv9e7oY50o6gsv0t5p6oXaKHBYOZsFD+fO0boULgq8lMy9S72cW5LhGWB Q8rRbQZm/pMxP4Hq5yTHoM16GeQzUbGdTe/9+0t+W/7R3njiR02Rfg6jIbw2RqIBCbLX ZB45lGOuHijVoh0MLoRa/VUcaU3f/USXKFOwQ=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Resubmitting the patch.

-dulloor

---------- Forwarded message ----------
From: Dulloor <dulloor@xxxxxxxxx>
Date: Tue, Mar 23, 2010 at 12:55 PM
Subject: Re: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity
To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Cc: Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx"
<xen-devel@xxxxxxxxxxxxxxxxxxx>


Please use this patch, in which length of bitmap is
(physinfo.max_cpu_id+1), rather than (physinfo.nr_cpus).

-dulloor

On Tue, Mar 23, 2010 at 12:41 PM, Dulloor <dulloor@xxxxxxxxx> wrote:
> I meant utils for **xenctl_cpumap**
>
> On Tue, Mar 23, 2010 at 12:40 PM, Dulloor <dulloor@xxxxxxxxx> wrote:
>> Fine, I agree with you both. Attached is a patch adding utils for
>> xenctl_bitmap (to libxc) and using the same in vcpu_(get|set)affinity.
>> For the guest-numa interface, I will see if I can use xenctl_cpumap.
>>
>> -dulloor
>>
>> On Tue, Mar 23, 2010 at 7:05 AM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 
>> wrote:
>>> On 23/03/2010 10:10, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>>>
>>>>>>> Dulloor <dulloor@xxxxxxxxx> 22.03.10 18:44 >>>
>>>>> Motivation for using xenctl_cpumask in Xen interfaces :
>>>>> - xenctl_cpumap is just 4 bytes smaller than static xenctl_cpumask for
>>>>> 128 cpus (128 would be good for quite some time). However, the new
>>>>
>>>> I don't buy this (we're already building for 256 CPUs, looking forward
>>>> to further bump this in the not too distant future), and I'm generally
>>>> opposed to introducing hard coded limits in a public interface.
>>>
>>> We should use xenctl_cpumask everywhere for specifying physical CPU bitmaps,
>>> even into guest NUMA interfaces if appropriate. I don't really care if it is
>>> a bit harder to use than a static bitmap.
>>>
>>>  -- Keir
>>>
>>>
>>>
>>
>

Attachment: cpumap-utils.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.