Re: [Xen-devel] [PATCH 6 of 6] PV on HVM suspend\resume

[Pasi Kärkkäinen <pasik@xxxxxx>]

On Tue, Apr 27, 2010 at 06:08:35AM +0100, Stefano Stabellini wrote:
> On Mon, 26 Apr 2010, Jeremy Fitzhardinge wrote:
> > On 04/25/2010 04:25 PM, Stefano Stabellini wrote:
> > >> This won't compile with CONFIG_PREEMPT enabled, because out_destroy_sm
> > >> is missing below.
> > >>
> > >>     
> > >  
> > > Now it is fixed,
> > 
> > Did you push out the fix (ideally as a new delta changeset on top of the
> > previous ones, rather than rebaseing them).
> > 
> 
> Yes but this time I rebased them; next time I'll keep the fix separated.
> 
> > 
> > >  however I tried suspend/resume with CONFIG_PREEMPT
> > > enabled and the kernel seems to hang at resume time; I wonder if it
> > > works for pv guests since the suspend/resume code is similiar...
> > >   
> > 
> > I think Pasi and IanC tested it quite a bit not too long ago, but its
> > possible they didn't test preempt kernels (and it wouldn't surprise me
> > at all if preempt breaks things).
> > 
> 
> all right, more debugging required here...
>

I was testing a lot with normal PV guests.. kernel .config was based
on standard Fedora kernels:

$ grep -i empt config-2.6.32.11-99.fc12.x86_64
# CONFIG_TREE_PREEMPT_RCU is not set
CONFIG_PREEMPT_NOTIFIERS=y
# CONFIG_PREEMPT_NONE is not set
CONFIG_PREEMPT_VOLUNTARY=y
# CONFIG_PREEMPT is not set


$ grep -i empt config-2.6.32.9-70.fc12.i686.PAE
# CONFIG_TREE_PREEMPT_RCU is not set
CONFIG_PREEMPT_NOTIFIERS=y
# CONFIG_PREEMPT_NONE is not set
CONFIG_PREEMPT_VOLUNTARY=y
# CONFIG_PREEMPT is not set


-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel