Re: [Xen-devel] [PATCH] xl: support specifing '[vars]' in 'xl create'

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 29 Apr 2010, Yu Zhiguo wrote:
> Hi Stefano,
> 
> Stefano Stabellini wrote:
> >> -static int create_domain(int debug, int daemonize, const char 
> >> *config_file, const char *restore_file, int paused, int migrate_fd /* -1 
> >> means none */, char **migration_domname_r)
> >> +static int create_domain(int debug, int daemonize, const char 
> >> *config_file, const char *restore_file,
> >> +                         int paused, int migrate_fd /* -1 means none */, 
> >> char **migration_domname_r,
> >> +                         const char *extra_config)
> > 
> > This line is misaligned.
> > Also, I feel that create_domain's arguments are growing too much, it would
> > be a good idea to reorganize them in a struct.
> > 
> 
> Thanks for you advice, I think it's a good idea and fix the patch.
> Could you ack the new version?
> 

This patch looks good.

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel