[Xen-devel] Re: [PATCH] syslog support to xentoollog

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Gihan Munasinghe writes ("[PATCH] syslog support to xentoollog"):
> Going forward I would like to suggest that xentoollog.h file should only 
> have generic functions, except for xtl_createlogger_* functions. Logger 
> type specific function should not be included(e.g 
> xtl_stdiostream_set_minlevel ) this will make sure outside code can 
> switch from one logger to another (from stdiologger to syslogger vice 
> versa) with out breaking the code.

In general this is a good idea but it's not sensible to make it a hard
and fast rule.  Eg, if you had a function xtl_syslog_change_facility()
it wouldn't make any sense for it to be implemented by stdiostream.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel