[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] Introduce dom0-min-space configuration option


  • To: Michal Novotny <minovotn@xxxxxxxxxx>
  • From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
  • Date: Mon, 26 Jul 2010 11:59:25 +0200
  • Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
  • Delivery-date: Mon, 26 Jul 2010 03:00:54 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=q4WGyrkKCzBPyinmAONaFe4W7nK4BVdT+zgJJ1/fjAJkWNfNxX1Vl5BWefPxQEpG82 kViG0d+blhj6k4mMfnK+LOeT4pOTZPJXqT+urw+S5WeKlBwJWlRJ0bSEyV2g8zDdUMOL IIA3I7vOquLXn1yHJiFRtCsqcy53Mbtf4LimY=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 07/26/2010 08:55 AM, Michal Novotny wrote:
Or do you think that we should alter the message in gunzip function to
say that there's an error in data stream (premature end of data stream)
and that user should check for enough space on dom0?

No, the gunzip function (in libxc, if I understood the context) should not even be called if pygrub could not write the file. Instead, it should print something like

pygrub: No space left on device

and exit.  There's absolutely no error checking here:

    data = fs.open_file(chosencfg["kernel"]).read()
    (tfd, bootcfg["kernel"]) = tempfile.mkstemp(prefix="boot_kernel.",
        dir="/var/run/xend/boot")
    os.write(tfd, data)
    os.close(tfd)

(and likewise for initrd) and that's the bug.

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.