[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [Patch] use full-size cpumask for vcpu-pin
On 13/08/2010 14:25, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote: > On 13/08/2010 14:21, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote: > >>> Since Xen discards any CPUs which are not online at the time of the >>> setvcpuaffinity hypercall, expressing "all CPUs present and future" is a bit >>> pointless. >> >> Hm, no, I'm talking rubbish. Argh. Okay, his patch is fine then. :-D >> >> You can check it in to xen-unstable-tools.hg. > > One suggestion: that we rename the syctl.physinfo field 'max_phys_cpus' to > 'max_possible_cpus'. The 'phys' is kind of redundant since this is the > physinfo sysctl, and 'possible' provides a better hint that this fields > indicates maximum possible supported CPUs now and forever on this boot of > the system. Even better, let's not introduce a new field at all, and let's always set sysctl.phys_info.max_cpu_id to NR_CPUS-1. Then I don't think any tools changes are needed. Yeah, that's what we should do. I will make a patch for that. -- Keir > -- Keir > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |